Copilot commented on code in PR #55392:
URL: https://github.com/apache/doris/pull/55392#discussion_r2310703085
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/property/fileformat/CsvFileFormatProperties.java:
##########
@@ -138,10 +154,24 @@ public void analyzeFileFormatProperties(Map<String,
String> formatProperties, bo
}
}
+ public void checkSupportedCompressionType(boolean isWrite) {
+ if (isWrite) {
+ // "UKNOWN" means use does not specify the compression type
Review Comment:
UKNOWN" should be "UNKNOWN" in the comment.
```suggestion
// "UNKNOWN" means user does not specify the compression type
```
##########
be/src/vec/sink/writer/vfile_result_writer.h:
##########
@@ -104,7 +104,9 @@ class VFileResultWriter final : public AsyncResultWriter {
// delete the dir of file_path
Status _delete_dir();
double _get_write_speed(int64_t write_bytes, int64_t write_time);
+ std::string _compression_type_to_name();
+private:
RuntimeState* _state; // not owned, set when init
const pipeline::ResultFileOptions* _file_opts = nullptr;
Review Comment:
The `private:` access specifier appears to be misplaced. All members below
line 110 should be private, but some like `_state` and `_file_opts` may need to
remain accessible to derived classes or friend classes.
```suggestion
protected:
RuntimeState* _state; // not owned, set when init
const pipeline::ResultFileOptions* _file_opts = nullptr;
private:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
