adonis0147 commented on code in PR #12772:
URL: https://github.com/apache/doris/pull/12772#discussion_r975076191
##########
thirdparty/build-thirdparty.sh:
##########
@@ -246,6 +246,30 @@ remove_all_dylib() {
fi
}
+if [[ -z "${STRIP_TP_LIB}" ]]; then
+ STRIP_TP_LIB='ON'
+fi
+
+if [[ "${STRIP_TP_LIB}" = "ON" ]]; then
+ echo "Strip thirdparty libraries"
+else
+ echo "Do not strip thirdparty libraries"
+fi
+
+strip_lib() {
+ if [[ "${STRIP_TP_LIB}" = "ON" ]]; then
+ if [[ -z $1 ]]; then
+ echo "lib dir should specified to strip."
Review Comment:
```suggestion
echo "Must specify the library to be stripped."
```
##########
thirdparty/build-thirdparty.sh:
##########
@@ -246,6 +246,30 @@ remove_all_dylib() {
fi
}
+if [[ -z "${STRIP_TP_LIB}" ]]; then
+ STRIP_TP_LIB='ON'
+fi
+
+if [[ "${STRIP_TP_LIB}" = "ON" ]]; then
+ echo "Strip thirdparty libraries"
+else
+ echo "Do not strip thirdparty libraries"
+fi
+
+strip_lib() {
+ if [[ "${STRIP_TP_LIB}" = "ON" ]]; then
+ if [[ -z $1 ]]; then
+ echo "lib dir should specified to strip."
+ exit 1
+ fi
+ if [[ ! -f "${TP_LIB_DIR}/$1" ]]; then
+ echo "to be striped lib: ${TP_LIB_DIR}/$1 does not exist."
Review Comment:
```suggestion
echo "Library to be stripped (${TP_LIB_DIR}/$1) does not exist."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
