zclllyybb commented on code in PR #55749:
URL: https://github.com/apache/doris/pull/55749#discussion_r2328625129
##########
be/src/vec/common/custom_allocator.h:
##########
@@ -33,6 +35,69 @@ template <class Key, class T, class Compare = std::less<Key>,
class Allocator = CustomStdAllocator<std::pair<const Key, T>>>
using DorisMap = std::map<Key, T, Compare, Allocator>;
+template <typename T>
+struct DorisUniqueBufferDeleter {
+ Allocator<false> allocator;
Review Comment:
`Allocator` is an empty class. maybe inheriting is a better solution than
being a member because of EBO(empty base class optimization)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
