Mryange commented on code in PR #55633:
URL: https://github.com/apache/doris/pull/55633#discussion_r2328984136
##########
be/src/vec/columns/column.h:
##########
@@ -652,6 +652,10 @@ class IColumn : public COW<IColumn> {
// only wrok on column_vector and column column decimal, there will be no
behavior when other columns type call this method
virtual void replace_column_null_data(const uint8_t* __restrict null_map)
{}
+ // For float/double types, replace -0.0 with 0.0, set NaN to quiet NaN,
+ // used to ensure data hash equality for -0.0 and +0.0, e.g. aggregate and
join
+ virtual void replace_float_special_values() {}
Review Comment:
这个函数是不是array，map，const 这种也要写一下。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
