xy720 commented on code in PR #55753:
URL: https://github.com/apache/doris/pull/55753#discussion_r2329510763
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/CatalogRecycleBin.java:
##########
@@ -182,6 +191,8 @@ public synchronized boolean recycleTable(long dbId, Table
table, boolean isRepla
}
idToRecycleTime.put(table.getId(), recycleTime);
idToTable.put(table.getId(), tableInfo);
+ String key = dbId + "_" + table.getName();
Review Comment:
I just realized using `dbId + "_" + tableName` is a bad idea because
tablet/partition name may contains "_".
So I used a Map<Pair<Long, String>, Set<Long>> structure instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
