w41ter commented on code in PR #55776:
URL: https://github.com/apache/doris/pull/55776#discussion_r2335336449
##########
cloud/src/meta-store/txn_kv.cpp:
##########
@@ -686,6 +692,9 @@ TxnErrorCode Transaction::commit() {
}
Review Comment:
Line 690 might leak the versionstamp_fut.
##########
cloud/src/meta-store/txn_kv.cpp:
##########
@@ -673,6 +673,12 @@ TxnErrorCode Transaction::commit() {
fdb_error_t err = 0;
TEST_INJECTION_POINT_CALLBACK("Transaction::commit.inject_random_fault",
&err);
TEST_SYNC_POINT_CALLBACK("transaction:commit:get_err", &err);
+
+ FDBFuture* versionstamp_fut = nullptr;
Review Comment:
Consider using DORIS_CLOUD_DEFER to avoid memory leaks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
