Copilot commented on code in PR #55863:
URL: https://github.com/apache/doris/pull/55863#discussion_r2335926111


##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -2014,8 +2013,8 @@ public HttpStreamParams generateHttpStreamPlan(TUniqueId 
queryId) throws Excepti
                 }
                 if (e instanceof NereidsException) {
                     LOG.warn("Analyze failed. {}", 
context.getQueryIdentifier(), e);
-                    throw ((NereidsException) e).getException();
                 }
+                throw e;

Review Comment:
   The removal of the specific exception handling for NereidsException breaks 
the original logic. The code should still throw the nested exception from 
NereidsException rather than the wrapper exception itself.
   ```suggestion
                   if (e instanceof NereidsException && e.getCause() != null) {
                       // Restore original logic: throw the nested cause of 
NereidsException
                       if (e.getCause() instanceof Exception) {
                           throw (Exception) e.getCause();
                       } else if (e.getCause() instanceof Error) {
                           throw (Error) e.getCause();
                       } else {
                           throw new RuntimeException(e.getCause());
                       }
                   } else {
                       throw e;
                   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to