wumeibanfa commented on code in PR #55719:
URL: https://github.com/apache/doris/pull/55719#discussion_r2342856024
##########
be/src/util/bitmap_value.h:
##########
@@ -2431,12 +2432,12 @@ class BitmapValue {
BITMAP = 2, // more than one elements
SET = 3 // elements count less or equal than 32
};
- uint64_t _sv = 0; // store the single value
when _type == SINGLE
- std::shared_ptr<detail::Roaring64Map> _bitmap; // used when _type == BITMAP
+ uint64_t _sv = 0; // store the single value when _type == SINGLE
+ mutable std::shared_ptr<detail::Roaring64Map> _bitmap; // used when _type
== BITMAP
Review Comment:
getSizeInBytes()
使用了_prepare_bitmap_for_write，会修改_bitmap，但是这里一般使用只为了获取大小，最好的办法应该是删除_prepare_bitmap_for_write？但是这样的改动或许需要评估一下，也就是这里为什么要使用_prepare_bitmap_for_write
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
