amorynan commented on code in PR #55941:
URL: https://github.com/apache/doris/pull/55941#discussion_r2343217110
##########
be/src/olap/rowset/segment_v2/variant/hierarchical_data_iterator.cpp:
##########
@@ -48,7 +48,7 @@ Status HierarchicalDataIterator::create(ColumnIteratorUPtr*
reader, int32_t col_
ColumnReaderCache* column_reader_cache,
OlapReaderStatistics* stats) {
// None leave node need merge with root
- auto stream_iter = std::make_unique<HierarchicalDataIterator>(path);
+ std::unique_ptr<HierarchicalDataIterator> stream_iter(new
HierarchicalDataIterator(path));
Review Comment:
why here use new HierarchicalDataIterator(path) ? if new fail , here may
meet some memory-leak, I think origin is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
