BiteTheDDDDt commented on code in PR #55719:
URL: https://github.com/apache/doris/pull/55719#discussion_r2347756280
##########
be/src/vec/aggregate_functions/aggregate_function.h:
##########
@@ -131,27 +131,25 @@ class IAggregateFunction {
std::vector<int>& rows, Arena&) const {}
/// Merges state (on which place points to) with other state of current
aggregation function.
- virtual void merge(AggregateDataPtr __restrict place,
ConstAggregateDataPtr rhs,
- Arena&) const = 0;
+ virtual void merge(AggregateDataPtr __restrict place, AggregateDataPtr
rhs, Arena&) const = 0;
Review Comment:
具体是什么函数需要非const的rhs?
还有其他的ConstAggregateDataPtr似乎都被改掉了，我觉得不一定合理。比如像serialize为什么会需要修改输入的AggregateData呢？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
