This is an automated email from the ASF dual-hosted git repository.
w41ter pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 25db11ce702 [chore](cloud) Add drop_snapshot method (#55958)
25db11ce702 is described below
commit 25db11ce702d16fced83bee6c05f99176b618a2e
Author: walter <[email protected]>
AuthorDate: Mon Sep 15 15:42:51 2025 +0800
[chore](cloud) Add drop_snapshot method (#55958)
---
cloud/src/meta-service/meta_service.h | 10 ++++++++++
cloud/src/meta-service/meta_service_snapshot.cpp | 8 ++++++++
gensrc/proto/cloud.proto | 11 +++++++++++
3 files changed, 29 insertions(+)
diff --git a/cloud/src/meta-service/meta_service.h
b/cloud/src/meta-service/meta_service.h
index 38cc77aebb0..5328711d88f 100644
--- a/cloud/src/meta-service/meta_service.h
+++ b/cloud/src/meta-service/meta_service.h
@@ -357,6 +357,10 @@ public:
const ListSnapshotRequest* request,
ListSnapshotResponse* response,
::google::protobuf::Closure* done) override;
+ void drop_snapshot(::google::protobuf::RpcController* controller,
+ const DropSnapshotRequest* request,
DropSnapshotResponse* response,
+ ::google::protobuf::Closure* done) override;
+
void clone_instance(::google::protobuf::RpcController* controller,
const CloneInstanceRequest* request,
CloneInstanceResponse* response,
::google::protobuf::Closure* done) override;
@@ -865,6 +869,12 @@ public:
call_impl(&cloud::MetaService::list_snapshot, controller, request,
response, done);
}
+ void drop_snapshot(::google::protobuf::RpcController* controller,
+ const DropSnapshotRequest* request,
DropSnapshotResponse* response,
+ ::google::protobuf::Closure* done) override {
+ call_impl(&cloud::MetaService::drop_snapshot, controller, request,
response, done);
+ }
+
void clone_instance(::google::protobuf::RpcController* controller,
const CloneInstanceRequest* request,
CloneInstanceResponse* response,
::google::protobuf::Closure* done) override {
diff --git a/cloud/src/meta-service/meta_service_snapshot.cpp
b/cloud/src/meta-service/meta_service_snapshot.cpp
index e2c8e395a63..aa03f88efdb 100644
--- a/cloud/src/meta-service/meta_service_snapshot.cpp
+++ b/cloud/src/meta-service/meta_service_snapshot.cpp
@@ -199,4 +199,12 @@ void
MetaServiceImpl::clone_instance(::google::protobuf::RpcController* controll
controller->SetFailed("Method clone_instance() not implemented.");
}
+void MetaServiceImpl::drop_snapshot(::google::protobuf::RpcController*
controller,
+ const DropSnapshotRequest* request,
+ DropSnapshotResponse* response,
+ ::google::protobuf::Closure* done) {
+ brpc::ClosureGuard done_guard(done);
+ controller->SetFailed("Method drop_snapshot() not implemented.");
+}
+
} // namespace doris::cloud
diff --git a/gensrc/proto/cloud.proto b/gensrc/proto/cloud.proto
index e277c24f8d7..bfaca8fb4b9 100644
--- a/gensrc/proto/cloud.proto
+++ b/gensrc/proto/cloud.proto
@@ -1968,6 +1968,16 @@ message ListSnapshotResponse {
repeated SnapshotInfoPB snapshots = 2;
}
+message DropSnapshotRequest {
+ optional string cloud_unique_id = 1;
+ optional string snapshot_id = 2; // The snapshot to drop
+ optional string request_ip = 3;
+}
+
+message DropSnapshotResponse {
+ optional MetaServiceResponseStatus status = 1;
+}
+
message CloneInstanceRequest {
enum CloneType {
UNKNOWN = 0;
@@ -2076,6 +2086,7 @@ service MetaService {
rpc begin_snapshot(BeginSnapshotRequest) returns (BeginSnapshotResponse);
rpc commit_snapshot(CommitSnapshotRequest) returns
(CommitSnapshotResponse);
rpc abort_snapshot(AbortSnapshotRequest) returns (AbortSnapshotResponse);
+ rpc drop_snapshot(DropSnapshotRequest) returns (DropSnapshotResponse);
rpc list_snapshot(ListSnapshotRequest) returns (ListSnapshotResponse);
rpc clone_instance(CloneInstanceRequest) returns (CloneInstanceResponse);
};
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
