This is an automated email from the ASF dual-hosted git repository.
starocean999 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 54f60de478a [fix](view)Fix show create view not display
column_definition (#55819)
54f60de478a is described below
commit 54f60de478aab9f9987e383bf46ddc83d92f5f6d
Author: zhangdong <[email protected]>
AuthorDate: Tue Sep 16 16:51:30 2025 +0800
[fix](view)Fix show create view not display column_definition (#55819)
```
CREATE VIEW v2
(
k11,
v1 comment "v1_comment"
)
COMMENT "my first view"
AS
SELECT k1,SUM(k2) FROM user group by k1;
```
```
mysql> show create view v2\G
*************************** 1. row ***************************
View: v2
Create View: CREATE VIEW `v2`
(k11,v1 comment 'v1_comment')
COMMENT 'my first view' AS SELECT `internal`.`zd`.`user`.`k1` AS `k11`,
SUM(`internal`.`zd`.`user`.`k2`) AS `v1` FROM `internal`.`zd`.`user` group by
`internal`.`zd`.`user`.`k1`;
character_set_client: utf8mb4
collation_connection: utf8mb4_0900_bin
1 row in set (0.01 sec)
```
---
.../src/main/java/org/apache/doris/catalog/Env.java | 8 +++++---
.../scalar_types/get_assignment_compatible_type.out | Bin 753 -> 767 bytes
.../test_create_view_nereids.out | Bin 18763 -> 19317 bytes
.../data/ddl_p0/test_alter_view_nereids.out | Bin 1051 -> 1076 bytes
.../nereids_p0/ddl/show_view/show_view_command.out | Bin 1995 -> 2071 bytes
.../data/nereids_p0/show/test_show_create_view.out | Bin 763 -> 837 bytes
.../test_show_create_table_and_views_nereids.out | Bin 6596 -> 6614 bytes
.../create_view_star_except_and_cast_to_sql.out | Bin 739 -> 763 bytes
regression-test/data/view_p0/view_p0.out | Bin 3484 -> 3590 bytes
.../nereids_p0/show/test_show_create_view.groovy | 8 +++++++-
10 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
index 963ee148b19..637786bcd3b 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java
@@ -3546,7 +3546,7 @@ public class Env {
try {
StringBuilder sb = new StringBuilder("CREATE MATERIALIZED VIEW ");
sb.append(mtmv.getName());
- addMTMVCols(mtmv, sb);
+ addColNameAndComment(mtmv, sb);
sb.append("\n");
sb.append(mtmv.getRefreshInfo());
addMTMVKeyInfo(mtmv, sb);
@@ -3595,9 +3595,9 @@ public class Env {
sb.append(")");
}
- private static void addMTMVCols(MTMV mtmv, StringBuilder sb) {
+ private static void addColNameAndComment(TableIf tableIf, StringBuilder
sb) {
sb.append("\n(");
- List<Column> columns = mtmv.getBaseSchema();
+ List<Column> columns = tableIf.getBaseSchema();
for (int i = 0; i < columns.size(); i++) {
if (i != 0) {
sb.append(",");
@@ -4315,6 +4315,8 @@ public class Env {
View view = (View) table;
sb.append("CREATE VIEW `").append(table.getName()).append("`");
+ addColNameAndComment(view, sb);
+ sb.append("\n");
if (StringUtils.isNotBlank(table.getComment())) {
sb.append(" COMMENT '").append(table.getComment()).append("'");
}
diff --git
a/regression-test/data/datatype_p0/scalar_types/get_assignment_compatible_type.out
b/regression-test/data/datatype_p0/scalar_types/get_assignment_compatible_type.out
index 09b6e11c95f..f718757dea9 100644
Binary files
a/regression-test/data/datatype_p0/scalar_types/get_assignment_compatible_type.out
and
b/regression-test/data/datatype_p0/scalar_types/get_assignment_compatible_type.out
differ
diff --git
a/regression-test/data/ddl_p0/create_view_nereids/test_create_view_nereids.out
b/regression-test/data/ddl_p0/create_view_nereids/test_create_view_nereids.out
index 0356bb19d41..ee63cbb3446 100644
Binary files
a/regression-test/data/ddl_p0/create_view_nereids/test_create_view_nereids.out
and
b/regression-test/data/ddl_p0/create_view_nereids/test_create_view_nereids.out
differ
diff --git a/regression-test/data/ddl_p0/test_alter_view_nereids.out
b/regression-test/data/ddl_p0/test_alter_view_nereids.out
index a31a13f107a..e5196b6a59a 100644
Binary files a/regression-test/data/ddl_p0/test_alter_view_nereids.out and
b/regression-test/data/ddl_p0/test_alter_view_nereids.out differ
diff --git
a/regression-test/data/nereids_p0/ddl/show_view/show_view_command.out
b/regression-test/data/nereids_p0/ddl/show_view/show_view_command.out
index 33e1f8315bf..47268b6c2c8 100644
Binary files
a/regression-test/data/nereids_p0/ddl/show_view/show_view_command.out and
b/regression-test/data/nereids_p0/ddl/show_view/show_view_command.out differ
diff --git a/regression-test/data/nereids_p0/show/test_show_create_view.out
b/regression-test/data/nereids_p0/show/test_show_create_view.out
index 8ac669337b4..92f6e037194 100644
Binary files a/regression-test/data/nereids_p0/show/test_show_create_view.out
and b/regression-test/data/nereids_p0/show/test_show_create_view.out differ
diff --git
a/regression-test/data/show_p0/test_show_create_table_and_views_nereids.out
b/regression-test/data/show_p0/test_show_create_table_and_views_nereids.out
index 4549b98b0b3..fe47469aeb5 100644
Binary files
a/regression-test/data/show_p0/test_show_create_table_and_views_nereids.out and
b/regression-test/data/show_p0/test_show_create_table_and_views_nereids.out
differ
diff --git
a/regression-test/data/view_p0/create_view_star_except_and_cast_to_sql.out
b/regression-test/data/view_p0/create_view_star_except_and_cast_to_sql.out
index 3b8ebb65805..7d6b4157ff3 100644
Binary files
a/regression-test/data/view_p0/create_view_star_except_and_cast_to_sql.out and
b/regression-test/data/view_p0/create_view_star_except_and_cast_to_sql.out
differ
diff --git a/regression-test/data/view_p0/view_p0.out
b/regression-test/data/view_p0/view_p0.out
index 20702ab08e4..bfe587be741 100644
Binary files a/regression-test/data/view_p0/view_p0.out and
b/regression-test/data/view_p0/view_p0.out differ
diff --git
a/regression-test/suites/nereids_p0/show/test_show_create_view.groovy
b/regression-test/suites/nereids_p0/show/test_show_create_view.groovy
index 65ed4758a9a..0005e5e1e0c 100644
--- a/regression-test/suites/nereids_p0/show/test_show_create_view.groovy
+++ b/regression-test/suites/nereids_p0/show/test_show_create_view.groovy
@@ -60,7 +60,13 @@ suite("test_show_create_view", "query,arrow_flight_sql") {
// Create a view based on the new table
sql """
- CREATE VIEW IF NOT EXISTS ${view_name_2} AS
+ CREATE VIEW IF NOT EXISTS ${view_name_2}
+ (
+ k1,
+ k2 comment "k2_comment"
+ )
+ COMMENT "v2"
+ AS
SELECT key_field, value FROM ${table_name_2}
"""
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
