gavinchou commented on code in PR #56061:
URL: https://github.com/apache/doris/pull/56061#discussion_r2348261852
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -731,6 +731,27 @@ void internal_create_tablet(const CreateTabletsRequest*
request, MetaServiceCode
std::string key;
std::string val;
meta_tablet_key(key_info, &key);
+
+ if (txn->get(key, &val) == TxnErrorCode::TXN_OK) {
Review Comment:
we should also deal with ret code other than OK, such as timeout
interal_error etc...
otherwise it may be overwritten even if it is existed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
