wumeibanfa commented on code in PR #55719:
URL: https://github.com/apache/doris/pull/55719#discussion_r2348093844
##########
be/src/exprs/math_functions.cpp:
##########
@@ -98,7 +98,7 @@ double MathFunctions::my_double_round(double value, int64_t
dec, bool dec_unsign
return tmp2;
}
-StringRef MathFunctions::decimal_to_base(FunctionContext* ctx, int64_t
src_num, int8_t dest_base) {
+Slice MathFunctions::decimal_to_base(FunctionContext* ctx, int64_t src_num,
int8_t dest_base) {
Review Comment:
这个变动是由be/src/udf/udf.h 中改变 create_temp_string_val(int64_t len)
引起的，之前使用了stringRef，导致所有调用这个函数的位置都需要使用const_cast，因此直接修改为Slice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
