HappenLee commented on code in PR #56181:
URL: https://github.com/apache/doris/pull/56181#discussion_r2361889521


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/types/DataType.java:
##########
@@ -358,9 +358,8 @@ public static DataType 
convertPrimitiveFromStrings(List<String> types) {
                 break;
             case "varbinary":
                 // NOTICE, Maybe. not supported create table, and varbinary do 
not have len now
-                // dataType = VarBinaryType.INSTANCE;
-                // break;
-                throw new AnalysisException("doris do not support varbinary 
create table, could use it by catalog");
+                dataType = VarBinaryType.INSTANCE;

Review Comment:
   why delete the code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to