JNSimba commented on code in PR #56175:
URL: https://github.com/apache/doris/pull/56175#discussion_r2357762331


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/property/storage/StorageProperties.java:
##########
@@ -181,7 +179,9 @@ public static StorageProperties createPrimary(Map<String, 
String> origProps) {
                     props -> (isFsSupport(props, FS_BROKER_SUPPORT)
                             || BrokerProperties.guessIsMe(props)) ? new 
BrokerProperties(props) : null,
                     props -> (isFsSupport(props, FS_LOCAL_SUPPORT)
-                            || LocalProperties.guessIsMe(props)) ? new 
LocalProperties(props) : null
+                            || LocalProperties.guessIsMe(props)) ? new 
LocalProperties(props) : null,
+                    props -> (isFsSupport(props, FS_HDFS_SUPPORT)
+                            || HdfsProperties.guessIsMe(props)) ? new 
HdfsProperties(props) : null
             );

Review Comment:
   HDFS will validate the URI, causing errors, such as in the following URL: 
s3://test123/s3/demo/{1.csv,2.csv}
   Since this currently matches sequentially and doesn't require HDFS 
validation, placing it last can avoid this issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to