morrySnow commented on code in PR #56241:
URL: https://github.com/apache/doris/pull/56241#discussion_r2362311692
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/DateTimeExtractAndTransform.java:
##########
@@ -329,28 +330,53 @@ private static LocalDateTime firstDayOfWeek(LocalDateTime
dateTime) {
*/
@ExecFunction(name = "date_format")
public static Expression dateFormat(DateLiteral date, StringLikeLiteral
format) {
+ if (format.getValue().length() > 128) {
Review Comment:
could u help to add ut for these functions in FE?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/DateTimeExtractAndTransform.java:
##########
@@ -329,28 +330,53 @@ private static LocalDateTime firstDayOfWeek(LocalDateTime
dateTime) {
*/
@ExecFunction(name = "date_format")
public static Expression dateFormat(DateLiteral date, StringLikeLiteral
format) {
+ if (format.getValue().length() > 128) {
Review Comment:
could u help to add ut for these functions in FE?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/DateTimeExtractAndTransform.java:
##########
@@ -329,28 +330,53 @@ private static LocalDateTime firstDayOfWeek(LocalDateTime
dateTime) {
*/
@ExecFunction(name = "date_format")
public static Expression dateFormat(DateLiteral date, StringLikeLiteral
format) {
+ if (format.getValue().length() > 128) {
Review Comment:
could u help to add ut for these functions in FE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
