yiguolei commented on code in PR #55779:
URL: https://github.com/apache/doris/pull/55779#discussion_r2335312899
##########
be/src/vec/functions/function_jsonb.cpp:
##########
@@ -837,9 +836,8 @@ struct JsonbExtractStringImpl {
StringOP::push_value_string(std::string_view(find_result.value->typeName()), i,
res_data, res_offsets);
return;
- }
-
- if constexpr (std::is_same_v<DataTypeJsonb, ReturnType>) {
+ } else {
+ static_assert(std::is_same_v<DataTypeJsonb, ReturnType>);
Review Comment:
这里struct JsonbType : public JsonbExtractStringImpl<JsonbTypeType> {
static constexpr auto name = "json_type";
static constexpr auto alias = "jsonb_type";
}; 这个定义看着比较危险
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
