Gabriel39 commented on code in PR #13049:
URL: https://github.com/apache/doris/pull/13049#discussion_r983271273
##########
be/src/vec/functions/multiply.cpp:
##########
@@ -35,8 +35,8 @@ struct MultiplyImpl {
}
template <typename Result = DecimalV2Value>
- static inline DecimalV2Value apply(DecimalV2Value a, DecimalV2Value b) {
- return a * b;
+ static inline DecimalV2Value apply(const DecimalV2Value& a, const
DecimalV2Value& b) {
+ return DecimalV2Value((a.value() * b.value() - 1) /
DecimalV2Value::ONE_BILLION + 1);
Review Comment:
It's wrong if the result is negative
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
