eldenmoon opened a new pull request, #56382:
URL: https://github.com/apache/doris/pull/56382
This commit modified the caching logic for the Segment footer.
Previously, the Segment footer was cached in the `DATA_PAGE` cache. This was
incorrect as the footer is metadata, not data. This commit changes it to use
the more appropriate `INDEX_PAGE` cache.
Additionally, the calculation for `_meta_mem_usage` has been adjusted for
better accuracy. The footer size is no longer included in the calculation since
it's now managed by the `StoragePageCache`. The memory estimation for column
readers is also updated to use
`config::max_segment_partial_column_cache_size` for a more realistic value.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
