JNSimba commented on code in PR #339:
URL:
https://github.com/apache/doris-spark-connector/pull/339#discussion_r2378016041
##########
spark-doris-connector/spark-doris-connector-spark-3.5/src/main/scala/org/apache/doris/spark/read/DorisScanV2.scala:
##########
@@ -27,7 +27,7 @@ class DorisScanV2(config: DorisConfig, schema: StructType,
filters: Array[Predic
override protected def compiledFilters(): Array[String] = {
val inValueLengthLimit =
config.getValue(DorisOptions.DORIS_FILTER_QUERY_IN_MAX_COUNT)
val v2ExpressionBuilder = new V2ExpressionBuilder(inValueLengthLimit)
- filters.map(e =>
Option[String](v2ExpressionBuilder.build(e))).filter(_.isDefined).map(_.get)
Review Comment:
https://github.com/apache/doris-spark-connector/blob/0782940d2dd65cdc92d41bb25f425e986d3ded90/spark-doris-connector/spark-doris-connector-spark-3.5/src/main/scala/org/apache/doris/spark/read/DorisScanBuilder.scala#L38-L44
`v2ExpressionBuilder.build(e)` is also called here, but currently an
exception will be thrown in the `v2ExpressionBuilder.build(e)`. Does this also
need to be changed to the `buildOpt`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
