HappenLee commented on code in PR #56457:
URL: https://github.com/apache/doris/pull/56457#discussion_r2380764910
##########
be/src/util/cgroup_util.cpp:
##########
@@ -317,13 +317,19 @@ int CGroupUtil::get_cgroup_limited_cpu_number(int
physical_cores) {
// For cpuset, child cgroup's cpuset.cpus could not bigger thant parent's
cpuset.cpus.
if (CGroupUtil::cgroupsv2_enable()) {
std::string cgroupv2_process_path = CGroupUtil::cgroupv2_of_process();
+ std::filesystem::path current_cgroup_path;
Review Comment:
use the lambda to do the same work.
```
if (cgroupv2_process_path.empty()) {
current_cgroup_path = default_cgroups_mount;
} else {
current_cgroup_path = (default_cgroups_mount /
cgroupv2_process_path);
}
``` better be a lambda
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
