Mryange commented on code in PR #56402:
URL: https://github.com/apache/doris/pull/56402#discussion_r2384188691


##########
be/src/vec/data_types/data_type_number_base.cpp:
##########
@@ -48,6 +48,7 @@
 
 namespace doris::vectorized {
 #include "common/compile_check_begin.h"
+#ifdef BE_TEST
 template <PrimitiveType T>

Review Comment:
   > 如果我们的beut 依赖这种代码,而这段代码实际又没用,那么我们的beut 测试了个啥?
   
   有一些比较老的BEUT,在最后输出的时候用的这个函数。改beut比较麻烦,反正这里最后还是用的CastToString。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to