morrySnow commented on code in PR #56200: URL: https://github.com/apache/doris/pull/56200#discussion_r2384467724
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/ComputeSignatureForTimeArithmetic.java: ########## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.functions; + +import org.apache.doris.catalog.FunctionSignature; +import org.apache.doris.nereids.annotation.Developing; +import org.apache.doris.nereids.trees.expressions.literal.StringLikeLiteral; +import org.apache.doris.nereids.trees.expressions.literal.TimeV2Literal; +import org.apache.doris.nereids.types.TimeV2Type; + +/** + * use for literal in time arithmetic, such as time_add('12:34:56', INTERVAL 1 second). + * if the first argument is string like literal and could cast to legal time literal, + * then use TimeType signature rather than DatetimeV2 signature(usually in SIGNATURES). + * but won't add any signatures to SIGNATURES. normally there should be a TimeType signature in SIGNATURES. + */ +@Developing +public interface ComputeSignatureForTimeArithmetic extends ComputeSignature { + + @Override + default FunctionSignature computeSignature(FunctionSignature signature) { + FunctionSignature ret = ComputeSignature.super.computeSignature(signature); Review Comment: why compute this first? ########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/ComputeSignatureForTimeArithmetic.java: ########## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.functions; + +import org.apache.doris.catalog.FunctionSignature; +import org.apache.doris.nereids.annotation.Developing; +import org.apache.doris.nereids.trees.expressions.literal.StringLikeLiteral; +import org.apache.doris.nereids.trees.expressions.literal.TimeV2Literal; +import org.apache.doris.nereids.types.TimeV2Type; + +/** + * use for literal in time arithmetic, such as time_add('12:34:56', INTERVAL 1 second). + * if the first argument is string like literal and could cast to legal time literal, + * then use TimeType signature rather than DatetimeV2 signature(usually in SIGNATURES). + * but won't add any signatures to SIGNATURES. normally there should be a TimeType signature in SIGNATURES. + */ +@Developing +public interface ComputeSignatureForTimeArithmetic extends ComputeSignature { + + @Override + default FunctionSignature computeSignature(FunctionSignature signature) { + FunctionSignature ret = ComputeSignature.super.computeSignature(signature); + if (child(0) instanceof StringLikeLiteral) { + try { + String s = ((StringLikeLiteral) child(0)).getStringValue().trim(); + // check if the string is in the format of HH:MM:SS[.FFFFFF] + if (!s.contains("-")) { // avoid matching datetime format Review Comment: i think we support `2008/08/08` too, why just process '-' here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
