yiguolei commented on code in PR #56600:
URL: https://github.com/apache/doris/pull/56600#discussion_r2390163059


##########
be/src/vec/functions/function_bitmap.cpp:
##########
@@ -940,31 +937,28 @@ struct BitmapHasAll {
     using TData = std::vector<BitmapValue>;
     using ResTData = typename ColumnUInt8::Container;
 
-    static void vector_vector(const TData& lvec, const TData& rvec, ResTData& 
res) {
+    static void vector_vector(TData lvec, const TData& rvec, ResTData& res) {

Review Comment:
   这里不要改动类似接口的东西,比如这个lvec, 作为input,所有的vector_Vector 可能都是const TData& vec, 这个不要动。
   可以把原来的947 行做一些修改。改成 auto bitmap = lvec[i]; 这样显示的赋值一下就ok了。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to