sollhui commented on code in PR #56930:
URL: https://github.com/apache/doris/pull/56930#discussion_r2428089287
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskInfo.java:
##########
@@ -186,6 +188,21 @@ private void judgeEof(RLTaskTxnCommitAttachment
rlTaskTxnCommitAttachment) {
}
}
+ private void adaptiveMaxBatchInterval(RLTaskTxnCommitAttachment
rlTaskTxnCommitAttachment) {
+ RoutineLoadJob routineLoadJob = routineLoadManager.getJob(jobId);
+ if (rlTaskTxnCommitAttachment.getTotalRows() <
routineLoadJob.getMaxBatchRows()
+ && rlTaskTxnCommitAttachment.getReceivedBytes() <
routineLoadJob.getMaxBatchSizeBytes()
+ && rlTaskTxnCommitAttachment.getTaskExecutionTimeMs() >=
routineLoadJob.getMaxBatchIntervalS()) {
+ if (routineLoadJob.getMaxBatchIntervalS() <
Config.routine_load_adaptive_max_batch_interval_sec) {
+ routineLoadJob.setMaxBatchIntervalS(
+
Math.min(Config.routine_load_adaptive_max_batch_interval_sec,
Review Comment:
I think that increasing `max_batch_interval` will not improve throughput if
specified by user is greater than
`Config.routine_load_adaptive_max_batch_interval_sec`, so we will not handle it
and only deal with situations where the max batch interval is relatively small.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
