zclllyybb commented on code in PR #56807:
URL: https://github.com/apache/doris/pull/56807#discussion_r2428162391
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/ToDays.java:
##########
@@ -39,8 +39,8 @@ public class ToDays extends ScalarFunction
implements UnaryExpression, ExplicitlyCastableSignature,
PropagateNullableOnDateOrTimeLikeV2Args {
private static final List<FunctionSignature> SIGNATURES = ImmutableList.of(
-
FunctionSignature.ret(IntegerType.INSTANCE).args(DateV2Type.INSTANCE),
- FunctionSignature.ret(IntegerType.INSTANCE).args(DateType.INSTANCE)
+
FunctionSignature.ret(IntegerType.INSTANCE).args(DateTimeV2Type.SYSTEM_DEFAULT),
Review Comment:
这种要结合实际出发，应该把BE的datetime签名删掉，而不是FE补全。
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Timestamp.java:
##########
@@ -40,10 +39,10 @@ public class Timestamp extends ScalarFunction
//When enable_date_conversion is true, we prefer to V2 signature.
// This preference follows original planner. refer to
ScalarType.getDefaultDateType()
public static final List<FunctionSignature> SIGNATURES =
Config.enable_date_conversion ? ImmutableList.of(
-
FunctionSignature.ret(DateTimeV2Type.SYSTEM_DEFAULT).args(DateTimeV2Type.SYSTEM_DEFAULT),
-
FunctionSignature.ret(DateTimeType.INSTANCE).args(DateTimeType.INSTANCE)
- ) : ImmutableList.of(
-
FunctionSignature.ret(DateTimeType.INSTANCE).args(DateTimeType.INSTANCE),
+ FunctionSignature.ret(DateTimeV2Type.SYSTEM_DEFAULT)
Review Comment:
这儿格式是不是有问题
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/Timestamp.java:
##########
@@ -40,10 +39,10 @@ public class Timestamp extends ScalarFunction
//When enable_date_conversion is true, we prefer to V2 signature.
// This preference follows original planner. refer to
ScalarType.getDefaultDateType()
public static final List<FunctionSignature> SIGNATURES =
Config.enable_date_conversion ? ImmutableList.of(
-
FunctionSignature.ret(DateTimeV2Type.SYSTEM_DEFAULT).args(DateTimeV2Type.SYSTEM_DEFAULT),
-
FunctionSignature.ret(DateTimeType.INSTANCE).args(DateTimeType.INSTANCE)
- ) : ImmutableList.of(
-
FunctionSignature.ret(DateTimeType.INSTANCE).args(DateTimeType.INSTANCE),
+ FunctionSignature.ret(DateTimeV2Type.SYSTEM_DEFAULT)
Review Comment:
所有利用Config.enable_date_conversion进行签名判断的全都可以去掉了，默认这个值一定是true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
