This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 5214e898d9 [fix](parquet-reader) skip data/datatime column predicate
filter to avoid coredump (#13072)
5214e898d9 is described below
commit 5214e898d9655d10d3fc75c9e1f008c1246ab89f
Author: slothever <[email protected]>
AuthorDate: Sat Oct 8 18:02:35 2022 +0800
[fix](parquet-reader) skip data/datatime column predicate filter to avoid
coredump (#13072)
Will be fixed later
Co-authored-by: jinzhe <[email protected]>
---
be/src/vec/exec/format/parquet/parquet_pred_cmp.h | 50 ----------------------
.../exec/format/parquet/vparquet_column_reader.cpp | 1 +
2 files changed, 1 insertion(+), 50 deletions(-)
diff --git a/be/src/vec/exec/format/parquet/parquet_pred_cmp.h
b/be/src/vec/exec/format/parquet/parquet_pred_cmp.h
index 1b5d78bb12..517bab5d61 100644
--- a/be/src/vec/exec/format/parquet/parquet_pred_cmp.h
+++ b/be/src/vec/exec/format/parquet/parquet_pred_cmp.h
@@ -145,16 +145,6 @@ static bool _eval_eq(PrimitiveType conjunct_type, void*
value, const char* min_b
_FILTER_GROUP_BY_EQ_PRED(conjunct_value, min, max)
break;
}
- case TYPE_DOUBLE: {
- _PLAIN_DECODE(double, value, min_bytes, max_bytes, conjunct_value,
min, max)
- _FILTER_GROUP_BY_EQ_PRED(conjunct_value, min, max)
- break;
- }
- case TYPE_FLOAT: {
- _PLAIN_DECODE(float, value, min_bytes, max_bytes, conjunct_value, min,
max)
- _FILTER_GROUP_BY_EQ_PRED(conjunct_value, min, max)
- break;
- }
case TYPE_STRING:
case TYPE_VARCHAR:
case TYPE_CHAR:
@@ -194,16 +184,6 @@ static bool _eval_gt(PrimitiveType conjunct_type, void*
value, const char* max_b
_FILTER_GROUP_BY_GT_PRED(conjunct_value, max)
break;
}
- case TYPE_DOUBLE: {
- _PLAIN_DECODE_SINGLE(double, value, max_bytes, conjunct_value, max)
- _FILTER_GROUP_BY_GT_PRED(conjunct_value, max)
- break;
- }
- case TYPE_FLOAT: {
- _PLAIN_DECODE_SINGLE(float, value, max_bytes, conjunct_value, max)
- _FILTER_GROUP_BY_GT_PRED(conjunct_value, max)
- break;
- }
case TYPE_STRING:
case TYPE_VARCHAR:
case TYPE_CHAR:
@@ -244,16 +224,6 @@ static bool _eval_ge(PrimitiveType conjunct_type, void*
value, const char* max_b
_FILTER_GROUP_BY_GE_PRED(conjunct_value, max)
break;
}
- case TYPE_DOUBLE: {
- _PLAIN_DECODE_SINGLE(double, value, max_bytes, conjunct_value, max)
- _FILTER_GROUP_BY_GE_PRED(conjunct_value, max)
- break;
- }
- case TYPE_FLOAT: {
- _PLAIN_DECODE_SINGLE(float, value, max_bytes, conjunct_value, max)
- _FILTER_GROUP_BY_GE_PRED(conjunct_value, max)
- break;
- }
case TYPE_STRING:
case TYPE_VARCHAR:
case TYPE_CHAR:
@@ -294,16 +264,6 @@ static bool _eval_lt(PrimitiveType conjunct_type, void*
value, const char* min_b
_FILTER_GROUP_BY_LT_PRED(conjunct_value, min)
break;
}
- case TYPE_DOUBLE: {
- _PLAIN_DECODE_SINGLE(double, value, min_bytes, conjunct_value, min)
- _FILTER_GROUP_BY_LT_PRED(conjunct_value, min)
- break;
- }
- case TYPE_FLOAT: {
- _PLAIN_DECODE_SINGLE(float, value, min_bytes, conjunct_value, min)
- _FILTER_GROUP_BY_LT_PRED(conjunct_value, min)
- break;
- }
case TYPE_STRING:
case TYPE_VARCHAR:
case TYPE_CHAR:
@@ -344,16 +304,6 @@ static bool _eval_le(PrimitiveType conjunct_type, void*
value, const char* min_b
_FILTER_GROUP_BY_LE_PRED(conjunct_value, min)
break;
}
- case TYPE_DOUBLE: {
- _PLAIN_DECODE_SINGLE(double, value, min_bytes, conjunct_value, min)
- _FILTER_GROUP_BY_LE_PRED(conjunct_value, min)
- break;
- }
- case TYPE_FLOAT: {
- _PLAIN_DECODE_SINGLE(float, value, min_bytes, conjunct_value, min)
- _FILTER_GROUP_BY_LE_PRED(conjunct_value, min)
- break;
- }
case TYPE_STRING:
case TYPE_VARCHAR:
case TYPE_CHAR:
diff --git a/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp
b/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp
index 1bcb640865..5338c169f7 100644
--- a/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp
+++ b/be/src/vec/exec/format/parquet/vparquet_column_reader.cpp
@@ -65,6 +65,7 @@ void ParquetColumnReader::_generate_read_ranges(int64_t
start_index, int64_t end
std::list<RowRange>&
read_ranges) {
if (_row_ranges.size() == 0) {
read_ranges.emplace_back(start_index, end_index);
+ return;
}
int index = _row_range_index;
while (index < _row_ranges.size()) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
