cambyzju commented on code in PR #13088:
URL: https://github.com/apache/doris/pull/13088#discussion_r990630411
##########
be/src/vec/columns/predicate_column.h:
##########
@@ -134,17 +134,15 @@ class PredicateColumnType final : public
COWHelper<IColumn, PredicateColumnType<
}
void insert_many_default_type(const char* data_ptr, size_t num) {
- T* res_val_ptr = (T*)data.get_end_ptr();
- memcpy(res_val_ptr, data_ptr, num * sizeof(T));
- res_val_ptr += num;
- data.set_end_ptr(res_val_ptr);
Review Comment:
`data.resize(old_size + num);` will alloc memory and change end ptr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
