yiguolei commented on code in PR #56441:
URL: https://github.com/apache/doris/pull/56441#discussion_r2439373338
##########
be/src/olap/rowset/segment_v2/bloom_filter.h:
##########
@@ -194,7 +194,7 @@ class BloomFilter {
/// Bloom filters must have equal size and seed.
virtual bool contains(const BloomFilter& bf_) const { return true; };
- virtual char* data() const { return _data; }
Review Comment:
Bloomfilter structure should be immutable. If is is mutable, I think there
are many problems. For example, if we have a bloom filter index, and 2
concurrent queries, if one query thread modify bf, there will be crash.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
