wumeibanfa commented on code in PR #56600:
URL: https://github.com/apache/doris/pull/56600#discussion_r2389823512
##########
be/src/exprs/math_functions.h:
##########
@@ -34,8 +34,8 @@ class MathFunctions {
// Converts src_num in decimal to dest_base,
// and fills expr_val.string_val with the result.
- static doris::StringRef decimal_to_base(doris::FunctionContext* ctx,
int64_t src_num,
- int8_t dest_base);
+ static doris::Slice decimal_to_base(doris::FunctionContext* ctx, int64_t
src_num,
Review Comment:
I modified create_temp_string_val to change its return value from stringref
to slice. here use it, or use stringref(slice.data, slice.size) and remain the
return value is stringref?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
