CalvinKirs commented on code in PR #56579:
URL: https://github.com/apache/doris/pull/56579#discussion_r2386849092
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/property/storage/AbstractS3CompatibleProperties.java:
##########
@@ -131,15 +131,22 @@ public AwsCredentialsProvider getAwsCredentialsProvider()
{
public void initNormalizeAndCheckProps() {
super.initNormalizeAndCheckProps();
setEndpointIfPossible();
- if (!isValidEndpoint(getEndpoint())) {
- throw new IllegalArgumentException("Invalid endpoint: " +
getEndpoint());
- }
setRegionIfPossible();
//Allow anonymous access if both access_key and secret_key are empty
//But not recommended for production use.
if (StringUtils.isBlank(getAccessKey()) !=
StringUtils.isBlank(getSecretKey())) {
throw new IllegalArgumentException("Both the access key and the
secret key must be set.");
}
+ if (StringUtils.isBlank(getRegion())) {
+ throw new IllegalArgumentException("Region must be set.");
Review Comment:
endpoint must be stand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
