This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-4.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-4.0 by this push:
new 72cefb4acac branch-4.0: [fix](cache) fix incorrectly incrementing
s3_read_counter #55805 (#57105)
72cefb4acac is described below
commit 72cefb4acac7fc251740db057736049441e4b7bf
Author: github-actions[bot]
<41898282+github-actions[bot]@users.noreply.github.com>
AuthorDate: Sat Oct 18 11:16:21 2025 +0800
branch-4.0: [fix](cache) fix incorrectly incrementing s3_read_counter
#55805 (#57105)
Cherry-picked from #55805
Co-authored-by: Wen Zhenghu <[email protected]>
---
be/src/io/cache/cached_remote_file_reader.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/be/src/io/cache/cached_remote_file_reader.cpp
b/be/src/io/cache/cached_remote_file_reader.cpp
index 08c5960fb03..20747aa0317 100644
--- a/be/src/io/cache/cached_remote_file_reader.cpp
+++ b/be/src/io/cache/cached_remote_file_reader.cpp
@@ -42,7 +42,7 @@
namespace doris::io {
-bvar::Adder<uint64_t> s3_read_counter("cached_remote_reader_s3_read");
+bvar::Adder<uint64_t> remote_read_counter("cached_remote_reader_remote_read");
bvar::LatencyRecorder g_skip_cache_num("cached_remote_reader_skip_cache_num");
bvar::Adder<uint64_t> g_skip_cache_sum("cached_remote_reader_skip_cache_sum");
bvar::Adder<uint64_t> g_skip_local_cache_io_sum_bytes(
@@ -275,7 +275,7 @@ Status CachedRemoteFileReader::read_at_impl(size_t offset,
Slice result, size_t*
size_t size = empty_end - empty_start + 1;
std::unique_ptr<char[]> buffer(new char[size]);
{
- s3_read_counter << 1;
+ remote_read_counter << 1;
SCOPED_RAW_TIMER(&stats.remote_read_timer);
RETURN_IF_ERROR(_remote_file_reader->read_at(empty_start,
Slice(buffer.get(), size),
&size, io_ctx));
@@ -370,7 +370,7 @@ Status CachedRemoteFileReader::read_at_impl(size_t offset,
Slice result, size_t*
<< st.msg() << ", block state=" << block_state;
size_t bytes_read {0};
stats.hit_cache = false;
- s3_read_counter << 1;
+ remote_read_counter << 1;
SCOPED_RAW_TIMER(&stats.remote_read_timer);
RETURN_IF_ERROR(_remote_file_reader->read_at(
current_offset, Slice(result.data + (current_offset -
offset), read_size),
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
