morrySnow commented on code in PR #56659: URL: https://github.com/apache/doris/pull/56659#discussion_r2390260523
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/ComputeSignatureForSingleTimeArithmetic.java: ########## @@ -0,0 +1,118 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.functions; + +import org.apache.doris.catalog.FunctionSignature; +import org.apache.doris.nereids.annotation.Developing; +import org.apache.doris.nereids.trees.expressions.literal.StringLikeLiteral; +import org.apache.doris.nereids.trees.expressions.literal.TimeV2Literal; +import org.apache.doris.nereids.types.IntegerType; +import org.apache.doris.nereids.types.TimeV2Type; + +/** + * This is to ensure second('12:34:56') prioritizes matching time type, + * ensuring time string literals can correctly handle precision. + * if the first argument is string like literal and could cast to legal time + * literal, + * then use TimeType signature rather than DatetimeV2 signature(usually in + * SIGNATURES). + * but won't add any signatures to SIGNATURES. normally there should be a + * TimeType signature in SIGNATURES. + */ +@Developing +public interface ComputeSignatureForSingleTimeArithmetic extends ComputeSignature { + + @Override + default FunctionSignature computeSignature(FunctionSignature signature) { + if (child(0) instanceof StringLikeLiteral) { + try { + String s = ((StringLikeLiteral) child(0)).getStringValue().trim(); + if (isTimeFormat(s)) { + new TimeV2Literal(s); // check legality + TimeV2Type t1 = TimeV2Type.forTypeFromString(s); + int scale = t1.getScale(); + return FunctionSignature.ret(IntegerType.INSTANCE).args(TimeV2Type.of(scale)); + } + + } catch (Exception e) { + // string like literal cannot cast to a legal time/timeV2 literal + } + } + // Call the parent implementation for non-time formats + return ComputeSignature.super.computeSignature(signature); + } + + /** + * Check if the string is in a valid time format. + */ + default boolean isTimeFormat(String s) { Review Comment: better to add ut for these methods -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
