CalvinKirs commented on code in PR #56647:
URL: https://github.com/apache/doris/pull/56647#discussion_r2389722738
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/property/metastore/IcebergRestProperties.java:
##########
@@ -288,8 +288,8 @@ private void addOAuth2Properties() {
}
private void addGlueRestCatalogProperties() {
- if (Strings.isNotBlank(icebergRestSigningName) &&
icebergRestSigningName.equalsIgnoreCase("glue")) {
- icebergRestCatalogProperties.put("rest.signing-name", "glue");
+ if (Strings.isNotBlank(icebergRestSigningName)) {
+ icebergRestCatalogProperties.put("rest.signing-name",
icebergRestSigningName.toLowerCase());
icebergRestCatalogProperties.put("rest.sigv4-enabled",
icebergRestSigV4Enabled);
icebergRestCatalogProperties.put("rest.access-key-id",
icebergRestAccessKeyId);
Review Comment:
Or should we also add checks for **s3tables/glue**? Wouldn’t that be too
strict? If anything new gets added, we might need extra adaptations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
