gavinchou commented on code in PR #56651:
URL: https://github.com/apache/doris/pull/56651#discussion_r2388605955
##########
gensrc/proto/cloud.proto:
##########
@@ -2130,6 +2143,7 @@ service MetaService {
// streaming job meta
rpc get_streaming_task_commit_attach(GetStreamingTaskCommitAttachRequest)
returns (GetStreamingTaskCommitAttachResponse);
+ rpc delete_job_key(DeleteJobKeyRequest) returns (DeleteJobKeyResponse);
Review Comment:
比如 drop_streaming_job()
##########
gensrc/proto/cloud.proto:
##########
@@ -2130,6 +2143,7 @@ service MetaService {
// streaming job meta
rpc get_streaming_task_commit_attach(GetStreamingTaskCommitAttachRequest)
returns (GetStreamingTaskCommitAttachResponse);
+ rpc delete_job_key(DeleteJobKeyRequest) returns (DeleteJobKeyResponse);
Review Comment:
不适合暴露这么裸的接口给FE/BE
这里需要抽象成一系列的job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
