eldenmoon commented on code in PR #56803:
URL: https://github.com/apache/doris/pull/56803#discussion_r2428020495
##########
be/src/vec/core/field.cpp:
##########
@@ -114,6 +114,132 @@ void Field::create_concrete(const typename
PrimitiveTypeTraits<Type>::NearestFie
DCHECK_NE(type, PrimitiveType::INVALID_TYPE);
}
+void Field::create(Field&& field) {
+ switch (field.type) {
+ case PrimitiveType::TYPE_NULL:
Review Comment:
too many switch cases, maybe use macro?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
