HappenLee commented on code in PR #56998:
URL: https://github.com/apache/doris/pull/56998#discussion_r2438210556
##########
be/src/vec/common/sort/heap_sorter.cpp:
##########
@@ -17,17 +17,107 @@
#include "vec/common/sort/heap_sorter.h"
+#include "common/status.h"
+
namespace doris::vectorized {
#include "common/compile_check_begin.h"
-HeapSorter::HeapSorter(VSortExecExprs& vsort_exec_exprs, int64_t limit,
int64_t offset,
- ObjectPool* pool, std::vector<bool>& is_asc_order,
- std::vector<bool>& nulls_first, const RowDescriptor&
row_desc)
+template <bool with_runtime_predicate>
+HeapSorter<with_runtime_predicate>::HeapSorter(VSortExecExprs&
vsort_exec_exprs, int64_t limit,
Review Comment:
should be a new child class to do the work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
