csun5285 commented on code in PR #56159:
URL: https://github.com/apache/doris/pull/56159#discussion_r2375268161
##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -720,9 +720,10 @@ Status Segment::new_default_iterator(const TabletColumn&
tablet_column,
// in the new schema column c's cid == 2
// but in the old schema column b's cid == 2
// but they are not the same column
-Status Segment::new_column_iterator(const TabletColumn& tablet_column,
- std::unique_ptr<ColumnIterator>* iter,
- const StorageReadOptions* opt) {
+Status Segment::new_column_iterator(
+ const TabletColumn& tablet_column, std::unique_ptr<ColumnIterator>*
iter,
+ const StorageReadOptions* opt,
+ std::unordered_map<int32_t, PathToSparseColumnCacheUPtr>*
variant_sparse_column_cache) {
Review Comment:
这里用指针是因为有的调用 new_column_iterator 的地方没有这个map，这个map 只在segemnt_iterator 里面有
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
