w41ter commented on code in PR #56463:
URL: https://github.com/apache/doris/pull/56463#discussion_r2386538896
##########
cloud/src/meta-store/meta_reader.h:
##########
@@ -165,6 +165,18 @@ class MetaReader {
int64_t end_version,
std::vector<RowsetMetaCloudPB>* rowset_metas,
bool snapshot = false);
+ TxnErrorCode get_all_rowset_metas_at_versionstamp(int64_t start_version,
int64_t end_version,
+
std::vector<RowsetMetaCloudPB>* rowset_metas,
+ bool snapshot);
+ // Get all rowset meta for the given versionstamp and rowset version range
[start_version, end_version].
+ //
+ // The `rowset_metas` will be filled with the RowsetMetaCloudPB for each
version at versionstamp in the range,
+ // in ascending order.
+ TxnErrorCode get_all_rowset_metas_at_versionstamp(Transaction* txn,
int64_t start_version,
+ int64_t end_version,
+
std::vector<RowsetMetaCloudPB>* rowset_metas,
+ bool snapshot);
+
Review Comment:
```suggestion
// Get all tablet rowset metas for the given rowset version range
[start_version, end_version].
//
// The `rowset_metas` will be filled with the RowsetMetaCloudPB for each
version at versionstamp in the range,
// in ascending order.
TxnErrorCode get_all_tablet_rowset_metas(int64_t start_version, int64_t
end_version,
std::vector<RowsetMetaCloudPB>* rowset_metas,
bool snapshot);
TxnErrorCode get_all_tablet_rowset_metas(Transaction* txn, int64_t
start_version,
int64_t end_version,
std::vector<RowsetMetaCloudPB>* rowset_metas,
bool snapshot);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
