gavinchou commented on code in PR #56628:
URL: https://github.com/apache/doris/pull/56628#discussion_r2386897841


##########
cloud/src/recycler/s3_accessor.cpp:
##########
@@ -486,6 +486,18 @@ int S3Accessor::exists(const std::string& path) {
     return obj_client_->head_object({.bucket = conf_.bucket, .key = 
get_key(path)}, &obj_meta).ret;
 }
 
+int S3Accessor::abort_multipart_upload(const std::string& path, const 
std::string& upload_id) {

Review Comment:
   不管成功还是失败都打个日志, 失败还要打返回值



##########
cloud/src/recycler/s3_accessor.cpp:
##########
@@ -486,6 +486,18 @@ int S3Accessor::exists(const std::string& path) {
     return obj_client_->head_object({.bucket = conf_.bucket, .key = 
get_key(path)}, &obj_meta).ret;
 }
 
+int S3Accessor::abort_multipart_upload(const std::string& path, const 
std::string& upload_id) {

Review Comment:
   objclient的返回值



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to