w41ter commented on code in PR #56626:
URL: https://github.com/apache/doris/pull/56626#discussion_r2386860382
##########
cloud/src/meta-service/meta_service_snapshot.cpp:
##########
@@ -48,6 +48,30 @@ void
MetaServiceImpl::begin_snapshot(::google::protobuf::RpcController* controll
msg = response->status().msg();
}
+void MetaServiceImpl::update_snapshot(::google::protobuf::RpcController*
controller,
+ const UpdateSnapshotRequest* request,
+ UpdateSnapshotResponse* response,
+ ::google::protobuf::Closure* done) {
+ RPC_PREPROCESS(update_snapshot, get, put, del);
+ if (!request->has_cloud_unique_id() || request->cloud_unique_id().empty())
{
+ code = MetaServiceCode::INVALID_ARGUMENT;
+ msg = "cloud_unique_id not set";
+ return;
+ }
+
+ instance_id = get_instance_id(resource_mgr_, request->cloud_unique_id());
+ if (instance_id.empty()) {
+ code = MetaServiceCode::INVALID_ARGUMENT;
+ msg = "empty instance_id";
+ return;
+ }
+ RPC_RATE_LIMIT(begin_snapshot);
Review Comment:
```suggestion
RPC_RATE_LIMIT(update_snapshot);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
