This is an automated email from the ASF dual-hosted git repository.

gavinchou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new e486af8a326 [Fix](cloud) Fix cloud compile err (#56686)
e486af8a326 is described below

commit e486af8a3268518ca87561516c9dd8d0b2863f34
Author: deardeng <[email protected]>
AuthorDate: Fri Oct 10 09:24:03 2025 +0800

    [Fix](cloud) Fix cloud compile err (#56686)
    
    Fix cloud compile err, due to https://github.com/apache/doris/pull/56628
    ```
    /mnt/disk2/doris/apache_doris/cloud/src/recycler/azure_obj_client.h:29:7: 
error: abstract class is marked 'final' [-Werror,-Wabstract-final-class]
       29 | class AzureObjClient final : public ObjStorageClient {
          |       ^
    
/mnt/disk2/doris/apache_doris/cloud/src/recycler/obj_storage_client.h:106:35: 
note: unimplemented pure virtual method 'abort_multipart_upload' in 
'AzureObjClient'
      106 |     virtual ObjectStorageResponse 
abort_multipart_upload(ObjectStoragePathRef path,
          |                                   ^
    ```
---
 cloud/src/recycler/azure_obj_client.cpp | 8 ++++++++
 cloud/src/recycler/azure_obj_client.h   | 3 +++
 2 files changed, 11 insertions(+)

diff --git a/cloud/src/recycler/azure_obj_client.cpp 
b/cloud/src/recycler/azure_obj_client.cpp
index f3df2f9b6ee..38e022aa564 100644
--- a/cloud/src/recycler/azure_obj_client.cpp
+++ b/cloud/src/recycler/azure_obj_client.cpp
@@ -314,4 +314,12 @@ ObjectStorageResponse 
AzureObjClient::check_versioning(const std::string& bucket
     return {0};
 }
 
+ObjectStorageResponse 
AzureObjClient::abort_multipart_upload(ObjectStoragePathRef path,
+                                                             const 
std::string& upload_id) {
+    LOG_WARNING("abort_multipart_upload not implemented")
+            .tag("path", path.bucket + "/" + path.key)
+            .tag("upload_id", upload_id);
+    return {-1};
+}
+
 } // namespace doris::cloud
\ No newline at end of file
diff --git a/cloud/src/recycler/azure_obj_client.h 
b/cloud/src/recycler/azure_obj_client.h
index 96212d720a3..bdf9b4eda75 100644
--- a/cloud/src/recycler/azure_obj_client.h
+++ b/cloud/src/recycler/azure_obj_client.h
@@ -52,6 +52,9 @@ public:
 
     ObjectStorageResponse check_versioning(const std::string& bucket) override;
 
+    ObjectStorageResponse abort_multipart_upload(ObjectStoragePathRef path,
+                                                 const std::string& upload_id) 
override;
+
 private:
     std::shared_ptr<Azure::Storage::Blobs::BlobContainerClient> client_;
 };


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to