HappenLee commented on code in PR #56915:
URL: https://github.com/apache/doris/pull/56915#discussion_r2446800596
##########
be/src/vec/functions/function_date_or_datetime_to_string.cpp:
##########
@@ -102,11 +153,22 @@ class FunctionDateOrDateTimeToString : public IFunction {
res_offsets.resize(len);
size_t offset = 0;
+ auto* state = reinterpret_cast<LocaleDayMonthNameState*>(
+ context->get_function_state(FunctionContext::FRAGMENT_LOCAL));
+ const std::vector<std::string>* names_ptr = nullptr;
+ static const std::vector<std::string> empty_names;
Review Comment:
why here need empty_names, which case we need it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
