dataroaring commented on code in PR #57220:
URL: https://github.com/apache/doris/pull/57220#discussion_r2450834665
##########
be/src/olap/rowset/segment_v2/plain_page.h:
##########
@@ -204,7 +204,46 @@ class PlainPageDecoder : public PageDecoder {
}
Status next_batch(size_t* n, vectorized::MutableColumnPtr& dst) override {
- return Status::NotSupported("plain page not implement vec op now");
+ DCHECK(_parsed);
+ if (*n == 0 || _cur_idx >= _num_elems) [[unlikely]] {
+ *n = 0;
+ return Status::OK();
+ }
+
+ size_t max_fetch = std::min(*n, static_cast<size_t>(_num_elems -
_cur_idx));
+ const void* src_data = &_data[PLAIN_PAGE_HEADER_SIZE + _cur_idx *
SIZE_OF_TYPE];
+
+ dst->insert_many_fix_len_data((const char*)src_data, max_fetch);
+
+ *n = max_fetch;
+ _cur_idx += max_fetch;
+
+ return Status::OK();
+ }
+
+ Status read_by_rowids(const rowid_t* rowids, ordinal_t page_first_ordinal,
size_t* n,
+ vectorized::MutableColumnPtr& dst) override {
+ DCHECK(_parsed);
+ if (*n == 0) [[unlikely]] {
+ *n = 0;
Review Comment:
useless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
