924060929 commented on code in PR #57169:
URL: https://github.com/apache/doris/pull/57169#discussion_r2454617965


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PruneFileScanPartition.java:
##########
@@ -100,10 +102,10 @@ private SelectedPartitions 
pruneExternalPartitions(ExternalTable externalTable,
             sortedPartitionRanges = (Optional) partitionsCacheManager.get(
                             (SupportBinarySearchFilteringPartitions) 
externalTable, scan);
         }
-
-        List<String> prunedPartitions = new ArrayList<>(PartitionPruner.prune(
+        Pair<List<String>, Optional<Expression>> res = PartitionPruner.prune(
                 partitionSlots, filter.getPredicate(), nameToPartitionItem, 
ctx,
-                PartitionTableType.EXTERNAL, sortedPartitionRanges));
+                PartitionTableType.EXTERNAL, sortedPartitionRanges);
+        List<String> prunedPartitions = new ArrayList<>(res.first);

Review Comment:
   can you support prune predicates for the external table?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to