dataroaring commented on code in PR #13381:
URL: https://github.com/apache/doris/pull/13381#discussion_r995665586
##########
be/src/vec/exec/vaggregation_node.cpp:
##########
@@ -459,6 +459,7 @@ Status AggregationNode::open(RuntimeState* state) {
// this could cause unable to get JVM
if (_probe_expr_ctxs.empty()) {
_create_agg_status(_agg_data.without_key);
+ _agg_data_created_without_key = true;
Review Comment:
Could we use _probe_expr_ctxs.empty() as indicator, and do not introduce a
new variable _agg_data_created_without_key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
