zclllyybb commented on code in PR #57282:
URL: https://github.com/apache/doris/pull/57282#discussion_r2463000103


##########
regression-test/suites/doc/sql-manual/sql-functions/doc_date_functions_test.groovy:
##########
@@ -1368,6 +1368,29 @@ suite("doc_date_functions_test") {
     qt_yearweek_4 """SELECT YEARWEEK('2023-01-02', 5) AS yearweek_mode5"""
     qt_yearweek_5 """SELECT YEARWEEK('2023-12-25', 1) AS date_type_mode1"""
 
+    // 100. MAKETIME function test;
+    sql """DROP TABLE IF EXISTS maketime_test"""
+    sql """CREATE TABLE maketime_test (
+            `id` INT,
+            `hour` INT,
+            `minute` INT,
+            `sec` FLOAT
+        ) DUPLICATE KEY(id)
+        PROPERTIES ( 'replication_num' = '1' );"""
+    sql """ INSERT INTO maketime_test VALUES
+                (1, 12, 15, 30),
+                (2, 111, 0, 23.1234567),
+                (3, 1234, 11, 4),
+                (4, -1234, 6, 52),
+                (5, 20, 60, 12),
+                (6, 14, 51, 66),
+                (7, NULL, 15, 16),
+                (8, 7, NULL, 8),
+                (9, 1, 2, NULL);"""
+    qt_maketime_test_1 """SELECT MAKETIME(hour,minute,sec) FROM maketime_test 
ORDER BY id;"""
+    qt_maketime_test_2 """SELECT MAKETIME(hour, minute, 25) FROM maketime_test 
ORDER BY id;"""
+    sql """ DROP TABLE maketime_test; """

Review Comment:
   please dont drop table after test. if someone meets failure of this test, 
keep the table will be more helpful.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to