gavinchou commented on code in PR #57072: URL: https://github.com/apache/doris/pull/57072#discussion_r2467732751
########## be/src/io/cache/cache_block_meta_store.h: ########## @@ -0,0 +1,134 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <concurrentqueue.h> +#include <rocksdb/db.h> +#include <rocksdb/options.h> +#include <rocksdb/slice.h> +#include <rocksdb/status.h> + +#include <atomic> +#include <memory> +#include <mutex> +#include <string> +#include <thread> +#include <variant> +#include <vector> + +#include "io/cache/file_cache_common.h" +#include "util/threadpool.h" + +namespace doris::io { + +struct BlockMeta { + int type; + size_t size; + uint64_t ttl; + + BlockMeta() : type(0), size(0), ttl(0) {} + BlockMeta(int type_, size_t size_) : type(type_), size(size_), ttl(0) {} + BlockMeta(int type_, size_t size_, uint64_t ttl_) : type(type_), size(size_), ttl(ttl_) {} + + bool operator==(const BlockMeta& other) const { + return type == other.type && size == other.size && ttl == other.ttl; + } +}; + +struct BlockMetaKey { + int64_t tablet_id; + UInt128Wrapper hash; + size_t offset; + + BlockMetaKey() : tablet_id(0), hash(UInt128Wrapper(0)), offset(0) {} + BlockMetaKey(int64_t tablet_id_, UInt128Wrapper hash_, size_t offset_) + : tablet_id(tablet_id_), hash(hash_), offset(offset_) {} + + bool operator==(const BlockMetaKey& other) const { + return tablet_id == other.tablet_id && hash == other.hash && offset == other.offset; + } + + std::string to_string() const { + return std::to_string(tablet_id) + "_" + hash.to_string() + "_" + std::to_string(offset); Review Comment: this is not a correct encoding shceme, refer to keys.h/keys.cpp for more details e.g before encoding ``` tabelt_ids = 10086, 20, 3, 3 hash = a, b, c, c offset = 100, 30, 4, 10 ``` after encoding, it will produce keys with different order (unordered) ``` 10086_a_100 20_b_30 3_c_10 3_c_4 ``` we expect tablet_id = 10086 to be the last key. and for tablet_id=3, we expect encoded offset 10 is after 4. they are out of order, it does not have a correct rule to iterate over the KV store. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
