zclllyybb commented on code in PR #56807:
URL: https://github.com/apache/doris/pull/56807#discussion_r2468131928
##########
be/src/vec/functions/round.cpp:
##########
@@ -55,7 +55,6 @@ void register_function_round(SimpleFunctionFactory& factory) {
REGISTER_ROUND_FUNCTIONS_IMPL(IMPL, TYPE_DECIMAL32) \
REGISTER_ROUND_FUNCTIONS_IMPL(IMPL, TYPE_DECIMAL64) \
REGISTER_ROUND_FUNCTIONS_IMPL(IMPL, TYPE_DECIMAL128I) \
- REGISTER_ROUND_FUNCTIONS_IMPL(IMPL, TYPE_DECIMALV2) \
Review Comment:
dont remove decimalv2 this time
##########
be/src/vec/functions/function_date_or_datetime_computation.cpp:
##########
Review Comment:
we can combine v1 and v2 .cpp
##########
be/src/vec/functions/function_unary_arithmetic.h:
##########
@@ -54,19 +56,20 @@ struct PositiveImpl;
/// Used to indicate undefined operation
struct InvalidType;
-template <template <typename> class Op, typename Name>
+template <typename Op, typename Name, PrimitiveType param_type>
class FunctionUnaryArithmetic : public IFunction {
- static constexpr bool allow_decimal = std::is_same_v<Op<Int8>,
NegativeImpl<Int8>> ||
- std::is_same_v<Op<Int8>,
AbsImpl<Int8>> ||
- std::is_same_v<Op<Int8>,
PositiveImpl<Int8>>;
+ using DataType = typename PrimitiveTypeTraits<param_type>::DataType;
+ const bool allow_decimal =
Review Comment:
why not constexpr?
##########
be/test/olap/delta_writer_cluster_key_test.cpp:
##########
Review Comment:
dont remove origin v1 test. if relative test dont have v2 type, try to add
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
